[fpc-pascal] DBF Field name length and fpdbfexport

[michael.vancanneyt at wisa.be]

On Fri, 2 Sep 2011, Reinier Olislagers wrote:

> On 2-9-2011 13:23, michael.vancanneyt at wisa.be wrote:
>> On Fri, 2 Sep 2011, Reinier Olislagers wrote:
> <snip>
>>> In packages\fcl-db\src\export\fpdbfexport.pp
>>> These tablelevels/formats are defined:
>>>  TTableFormat = (tfDBaseIII,tfDBaseIV,tfDBaseVII,tfFoxPro);
>>>
>>> In function
>>> function TFPCustomDBFExport.BindFields: Boolean;
>>> there is this part (line 136):
>>>  If FormatSettings.AutoRenameFields and
>>> (FormatSettings.TableFormat=tfDbaseIII) then
>>>    CheckExportFieldNames;
>>>
>>> 1. Shouldn't this be amended to (don't know if you can use in in this
>>> way):
>>>  If FormatSettings.AutoRenameFields and (FormatSettings.TableFormat in
>>> [tfDbaseIII,tfDbaseIV,FoxPro]) then
>>>    CheckExportFieldNames;
> <sip>
>> Presumably, yes.
>>
>> Michael.
> Uploaded a patch, issue 20134
> http://bugs.freepascal.org/view.php?id=20134
>
> I think I've also found the solution to
> http://bugs.freepascal.org/view.php?id=20069
> (patch attached), so if somebody would be so kind to review & apply
> them, I'd be very happy.

You can start being happy.

Thanks for the patches!

Michael.