[fpc-devel] FPC black list details
pascaldragon at googlemail.com
Thu Dec 8 17:13:24 CET 2016
Am 08.12.2016 14:48 schrieb "Maciej Izak" <hnb.code at gmail.com>:
> 2016-12-08 14:34 GMT+01:00 Sven Barth <pascaldragon at googlemail.com>:
>> Small formal note: you should check the coding style of your patch
again. There are superfluous spaces among some expressions. ;) (also we
tend to use assigned() instead of a check for nil with (in)equality)
> True, thanks for note. Even spaces around "=" are wrong, and useless
"objdef: tobjectdef;" local variable. The patch is much older than MO
(almost 2 years old, was created before my more serious compiler work), I
forgot to rework this part. :\ Should I rework this patch again?
Also parameter declarations should have no spaces while local variables
have should a space before and after the colon...
If it isn't too much of an effort for you, then yes, rework it please.
Otherwise the one who commits that will have to remember that. :)
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the fpc-devel