[fpc-devel] Types.IntersectRect(), probably bug or misusage VERY URGENT

[Mattias Gaertner]

On Tue, 26 Oct 2010 17:31:48 +0200
zeljko <zeljko at holobit.net> wrote:

> On Tuesday 26 October 2010 16:57, Sergei Gorelkin wrote:
> 
> >
> > Well, maybe. For me, it is rather hard to think about the opposite - that a
> > const may be passed *not* by reference - due to long-term Delphi/Windows
> > experience.
> >
> > But, after all, Types.IntersectRect and surrounding stuff were introduced
> > and are intended as WinApi replacement, and WinApi IntersectRect() *does*
> > pass params by reference (they are originally PRect). So maybe it will be
> > still good to fix Types.IntersectRect to conform?
> 
> One note: IntersectRect in lazarus worked OK until we decided to use 
> Types.IntersectRect, old implementation from GraphType looks much better than 
> current fpc one.

Then it is probably better to undo the change.
Should I do that?

Mattias