[fpc-devel] can r12368 be merged to fixes?

Paul Ishenin webpirat at mail.ru
Tue Dec 16 12:45:12 CET 2008

Joost van der Sluis wrote:
> How can you expect us to merge a change a few hours after it's commit?
> We don't even know if the change compiles on all targets, so why should
> we even consider merging it? We'll always have to wait for the
> testsuite-run on all tested platforms (which is tonight.) 
Yes, testsuite is a good indicator. But does it needed in all cases? The 
main problem in Andrew case was just a typo:

if <condition> then ; do_something - it was just semicolon. Do we need 
to run testsuite in this case too?
> So in theory we could merge tomorrow. But as we are so close to a
> release we know that the change won't be tested very well before the
> release we have to e carefull. So give it a few days. But it also must
> be tested within fixes, so we can't merge just before we tag 2.2.4.
IMO if testsuite showed no negative differences and change was not big then there is no reason to wait that few other days :)
In other words someone committer need to look on change and decide:
a) it is very trivial change - no reason to wait
b) the change is not trivial - lets wait for few days

Best regards,
Paul Ishenin.

More information about the fpc-devel mailing list