[fpc-pascal] [Question] How to submit our patch?

[Sven Barth]

Jinyang He via fpc-pascal <fpc-pascal at lists.freepascal.org> schrieb am Mo.,
10. Okt. 2022, 11:47:

> We, a team working for Loongson, are ready to submit some patches which
> support a new architecture named LoongArch for FreePascal. [1] is one of
> repositories about LoongArch. LoongArch is a RISC architecture. The work
> of Loongson was based on MIPS in the past. So LoongArch is somewhat
> similar to MIPS. Of course, there are also commonalities with other RISC
> architectures such as aarch64, riscv, etc. Patches that support LoongArch
> also refer to many other architectures. I have to show my respect to the
> others who contributed FreePascal.
>
> Which way can we submit these patches? I guess we should create a
> 'merge requests' in Gitlab. Is it correct? I hope to find some official
> documentation, or some discussion from the list. All answers are
> needed. Thanks.
>
> [1] https://github.com/loongson


First of thank you for your desire to contribute support for the Loongson
architecture.

To answer your question, yes, a merge request is the best way, cause we can
comment easier. Preferably this is done on GitLab, our main repository, but
if it's really necessary youa can use GitHub as well, but you should notify
us about the request then, cause at least I don't monitor our GitHub
mirror.

Regarding the commits themselves: best split your commit up into the
following parts:

- adding the new architecture (without any target OS) to the compiler
- adding the loongson-linux target to the compiler
- adding the loongson-linux target and the loongson architecture in general
to the build utilities (fpmake and fpcmake)
- adding the RTL for loongson-linux
- changes to RTL/packages that are specific to the Loongson architecture in
general
- changes to RTL/packages that are specific to the loongson-linux target
- regenerating the makefiles (a separate commit, cause that's rather
"noisy")

Regards,
Sven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freepascal.org/pipermail/fpc-pascal/attachments/20221011/e20a7146/attachment.htm>