[fpc-pascal]ReAlloc Question

[James Mills]

On Fri, May 16, 2003 at 10:08:47PM +1000, James Mills wrote:
> On Fri, May 16, 2003 at 02:11:24PM +0200, Michael Van Canneyt wrote:
> > 
> > 
> > On Fri, 16 May 2003, James Mills wrote:
> > 
> > > On Fri, May 16, 2003 at 01:41:35PM +0200, Michael Van Canneyt wrote:
> > > >
> > > >
> > > > On Fri, 16 May 2003, James Mills wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > Can any problems with stringsclass.pas ?
> > > > > Reason I ask is that, yes my fairly large program works that uses
> > > > > dynamic memory allocation, however it has memory leaks galore! :(
> > > > > stringsclass.pas is a dynamic string class I created which I take pride
> > > > > in, but I'm not convinced I wrote the: procedure del(index: Integer);
> > > > > correctly...
> > > > > Could someone have a look and comment on that please ? It will aid
> > > > > greatly in my efforts to debug my memory leaks...
> > > >
> > > > With all due respect, but this is not exactly the most efficient code ever.
> > > > Did you have a look at the standard TStringList class ? It works very well,
> > > > and does all you do.
> > >
> > > Yeah I found out there was TStringList after I wrote it. And I'll agree
> > > with you, it's not the best code. However other classes that dynamically
> > > allocate objects in memory use similar code to that of stringsclass.pas
> > > so I need to get this right :)
> > >
> > > >
> > > >
> > > > Also, Class destructors MUST be called 'Destroy', not 'done'.
> > > Okay.
> > >
> > > >
> > > > Your method of calling init/done is also not quite correct, you're not
> > > > supposed to call the destructor unless you actually want to free your
> > > > class.
> > > >
> > > > If you want to stick to your class, try replacing your code with this=
> > > >
> > > > procedure TStrings.del(index: Integer);
> > > > var
> > > >  I : Integer;
> > > >
> > > > begin
> > > >  For I:=index to nstrings-1 do
> > > >    Strings[i]:=Strings[i+1];
> > > >  Dec(nstrings);
> > > >  ReallocMem(strings,sizeof(Shortstring)*nstrings);
> > > > end;
> > >
> > > Would this same technique work for a general dynamic array of objects ?
> > 
> > It should, unless you use memory pointers that point to specific memory
> > locations in the array.
> 
> I'll show you... Catch, datanicks.pas and nickclass.pas ...
> This is why I need to understand and fix this, it's not just a simple
> TStringList that I want to use :)

Forgot to attach em :(

cheers
James

> 
> thanks for your help ...
> 
> cheers
> James
> 
> > 
> > Michael.
> > 
> > 
> > _______________________________________________
> > fpc-pascal maillist  -  fpc-pascal at lists.freepascal.org
> > http://lists.freepascal.org/mailman/listinfo/fpc-pascal
> 
> _______________________________________________
> fpc-pascal maillist  -  fpc-pascal at lists.freepascal.org
> http://lists.freepascal.org/mailman/listinfo/fpc-pascal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: datanicks.pas
Type: text/x-pascal
Size: 5043 bytes
Desc: not available
URL: <http://lists.freepascal.org/pipermail/fpc-pascal/attachments/20030516/bb0f629b/attachment.pas>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nickclass.pas
Type: text/x-pascal
Size: 4846 bytes
Desc: not available
URL: <http://lists.freepascal.org/pipermail/fpc-pascal/attachments/20030516/bb0f629b/attachment-0001.pas>