[fpc-other] Fork

Graeme Geldenhuys graemeg.lists at gmail.com
Sun Oct 24 19:46:35 CEST 2010


On 24 October 2010 19:11, Marco van de Voort wrote:
>
> I don't understand what providing quick and dirty patches that ....

How do you get to 'quick and dirty'?  Not every small patch is a hack
or quick or dirty. The same applies for bigger patches. If the author
of the patch simply explains in the commit/patch message (git
automatically includes those when you email a patch, subversion
doesn't) what the patch does, and the reason for the patch, applying
that patch should be easier for the person reviewing that patch. They
have more detail regarding the patch and what it should do - no
guessing required.

But the FPC & Lazarus team set such bad examples (just review the
repository history and lengths of each commit message, new
contributors just follow suite. Sergei Gorelkin seems to be the
exception in the FPC team - he is about the only one that seems to
give (above agv) multi-line commit messages, explaining in more detail
what that commit does. Jonas Maebe being second after Sergei. Learn
from those two!


-- 
Regards,
  - Graeme -


_______________________________________________
fpGUI - a cross-platform Free Pascal GUI toolkit
http://opensoft.homeip.net:8080/fpgui/


More information about the fpc-other mailing list