[fpc-devel] Wrong version of db.pas in the fixes_3_2 branch?

[Sven Barth]

Michael Roland via fpc-devel <fpc-devel at lists.freepascal.org> schrieb am
Di., 1. Apr. 2025, 02:24:

> Is the wrong version of the db.pas in fixes_3_2 branch?
>

No.

>
>
> The current version of db.pas in fixes_3_2 seems to be from the 3.3.1
> branch instead of the 3.2.3 branch.
>

There have been changes from 3.3.1 that have been merged to 3.2.3.

>
>
> The 3.3.1 db.pas adds a new enum value ftSingle to TFieldType.
>

Correct.

>
>
> This causes the compilation of ZeosDb 8.0 ZAbstractRODataset.pas to fail
> with the error
>
>
>
> Error: Expected another 1 array elements.
>

Then Zeos code will have to be adjusted.

> The file zeosdbo-8.0.0-stable/src/ZeosLazarus.inc defines WITH_FTSINGLE as
>
>
>
> {$IF FPC_FULLVERSION >= 30300}
>
> {$DEFINE WITH_FTSINGLE}
>
> {$DEFINE WITH_FTSHORTINT}
>
> {$IFEND}
>
>
>
> So ZeosDb is doing the correct thing.
>

No, it's not. For ftSingle it needs to be adjusted.

The current db.pas file seems like a breaking change to make in the
> fixes_3_2 branch. Was the current db.pas file added to the fixes_3_2 branch
> for a reason, or was it added unintenionally?
>
Things like these can and do happen especially considering how old 3.2.2
is.



>
> Are any other files from the 3.3.1 branch in the fixes_3_2 branch?
>

There are no "files from the 3.3.1 branch" that were moved over (well,
expect maybe some new ones), just selected changes that were merged over.
This is simply how things work and third party software has to adjust their
checks. That's how it has always been.

Regards,
Sven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freepascal.org/pipermail/fpc-devel/attachments/20250401/df4ab8f3/attachment-0001.htm>