[fpc-devel] Request for review of patch for issue 40261

Bart bartjunk64 at gmail.com
Sat Sep 30 17:46:53 CEST 2023


Hi,

Issue 40261 is about TStrings.AddObject issueing 2 consecutive
OnChange events (and in the first one the to be added object is
unassigned when accessing Objects[] property) when using InsertObject,
AddObject and AddPair.
This is Delphi incompatible.

The patch attached to
https://gitlab.com/freepascal.org/fpc/source/-/issues/40261#note_1406426712
fixes this at the expense of calling BeginUpdate/EndUpdate (and for
that use a try..finally construct).

I kindly ask for this patch to be reviewed by one of the devels.

-- 
Bart


More information about the fpc-devel mailing list