[fpc-devel] Failing Lazarus Codetools Pas2JS-related tests

Maxim Ganetsky ganmax at narod.ru
Sun Dec 24 16:54:02 CET 2023


24.12.2023 17:24, Michael Van Canneyt пишет:
> 
> 
> On Sun, 24 Dec 2023, Maxim Ganetsky via fpc-devel wrote:
> 
>> 24.12.2023 01:07, Michael Van Canneyt via fpc-devel пишет:
>>>
>>>
>>> On Sat, 23 Dec 2023, Maxim Ganetsky via fpc-devel wrote:
>>>
>>>> 20.12.2023 12:36, Mattias Gaertner via fpc-devel пишет:
>>>>>
>>>>>
>>>>> On 20.12.23 10:18, Michael Van Canneyt via fpc-devel wrote:
>>>>>>
>>>>>> [...]
>>>>>>> Is this an FPC regression or the tests should be adapted somehow? 
>>>>>>> Can this be related to introduction of subtargets to Pas2JS?
>>>>>>
>>>>>> It could be, although I suspect it is more likely that the sources 
>>>>>> moved to
>>>>>> a subdir src in each of the package directories, to support 
>>>>>> namespaced
>>>>>> files.
>>>>>
>>>>> Yes.
>>>>>
>>>>>
>>>>>> I was not aware that there were tests for pas2js in the lazarus 
>>>>>> codebase, so yes, probably some tests or the underlying code in 
>>>>>> the IDE need to be adapted.
>>>>>
>>>>>
>>>>> utils/createconfig.pas needs to be adapted...
>>>> Any news on this? What changes are needed?
>>>
>>> As far as I know, Mattias is busy with it and has at least fixed the 
>>> tests ?
>>
>> I see the commit by Mattias now, but it does not affect config file 
>> created by `make install`, because the following duplicated code is 
>> used for creating config files when running `make install`:
>>
>> https://gitlab.com/freepascal.org/fpc/pas2js/-/blob/main/fpmake.pp?ref_type=heads#L20
> 
> I updated the config file writing. 2 files are written now. My local 
> tests are all OK.

Please elaborate. I just updated FPC and Pas2Js, nothing changed in 
behavior. Where is the commit?

-- 
Best regards,
  Maxim Ganetsky                  mailto:ganmax at narod.ru



More information about the fpc-devel mailing list