[fpc-devel] [Core] Haiku merges: Revision 42117

Karoly Balogh (Charlie/SGR) charlie at scenergy.dfmk.hu
Mon May 27 12:31:45 CEST 2019


On Mon, 27 May 2019, Pierre Muller wrote:

>   The merge of the two commits generate 3 conflicts, but those are easily solved.
> See attached patch.
>   Olivier, did you test the fixes_3_2 branch?
> Do you think it is reasonable to enable x86_64-haiku target in that branch?

I think if all the changes are merged, it's safe to enable at least, but
it needs to be tested of course. I only tested trunk.

>   charlie, you wrote those patches, thus
> it is probably best if you or Olivier decide:
> Should I merge them?

I think they should be merged, but Olivier is the maintainer. But as the
RTL changes are merged already (Marco did it after asking me), I think the
associated compiler changes should be merged too.

I'm unaware of any Haiku regressions compared to before my changes, OTOH
after my changes the entire thing is much cleaner and of course supports
x86_64 as well. If anyone is aware of any regression, I'm gladly fixing
them ASAP both in trunk and then it can be merged to 3.2 as well.


More information about the fpc-devel mailing list