[fpc-devel] Improvments to HTML Web Module

Michael Van Canneyt michael at freepascal.org
Sat Mar 3 10:31:55 CET 2018

On Fri, 2 Mar 2018, African Wild Dog wrote:

> I would like to propose (and develop, if authorized) the following
> improvements to the web module specialized in generating HTML content
> (TCustomHTTPModule):

I suppose you mean TCustomHTMLModule ?

Because TCustomHTTPModule is a base class.

It should not know anything of actions, HTML, sessions, whatnot.
It just needs to know how to handle a request: The HandleRequest abstract

> 1 - Add support for sessions;
> 2 - Add support for the use of actions (THTMLContentAction)

I have fixed 1 by descending TCustomHTMLModule from TSessionHTTPModule. 
It originally had support for sessions. That it lost this support was 
the result of a refactoring of session support... This is now fixed.
See revision 38397.

As for 2, what do you mean by this ? 
TCustomHTMLModule already supports HTML Content actions.
If you planned to actually add it to TCustomHTMLModule: 
No, that is not OK.

If there is something which prevents you from working with TCustomHTMLModule
other than session support (which is now fixed) we can discuss possible solutions.

For starters, it's an option to let it descend from TCustomFPWebModule
instead of TSessionHTTPModule. 
I have refactored TCustomFPWebModule so actions, template and template vars
can now be overridden by descendents, to make this possible. See rev. 38398.

Let me know if you have any other issues.


More information about the fpc-devel mailing list