[fpc-devel] AVR assembler code consistency checking

[Florian Klämpfl]

Am 22.01.2018 um 21:35 schrieb Christo:
> On Sat, 2018-01-06 at 16:03 +0100, Florian Klämpfl wrote:
>> Am 05.01.2018 um 11:24 schrieb Christo:
>>>
>>> On Wed, 2018-01-03 at 18:10 +0100, Florian Klämpfl wrote:
>>>>
>>>> Am 03.01.2018 um 15:48 schrieb Christo:
>>>>> Is there a better location in the compiler to implement some assembler consistency
>>>>> checks?
>>>>
>>>> fpc/compiler/avr/raavar.pas:TAVRInstruction.ConcatInstruction
> 
> Attached please find a patch for implementing some assembler validity checks for review.  I'm
> sure I've missed some tricks to optimize and reduce the code, but at least I would appreciate a
> check to see whether the logic of the different checks is sound. Particularly the bit that
> checks whether address registers are used correctly.

To me it looks good. I propose to commit if it breaks no existing code, time will tell if the checks
are ok :)