[fpc-devel] fppkg question

[Darius Blaszyk]

On May 14, 2011, at 12:26 PM, Joost van der Sluis wrote:

> On Fri, 2011-05-13 at 13:18 +0200, Michael Van Canneyt wrote:
>> 
>> On Fri, 13 May 2011, Darius Blaszyk wrote:
>> 
>>> 
>>> On May 13, 2011, at 1:01 PM, Michael Van Canneyt wrote:
>>> 
>>>> 
>>>> 
>>>> On Fri, 13 May 2011, Darius Blaszyk wrote:
>>>> 
>>>>>>> All this info is supposed to be output in XML format from fpmake
>>>>>>> --manifest. fppkg picks it up and stores it in the repository.
>>>>>>> 
>>>>>>> If you want to extend it to include a category and keywords, be my guest.
>>>>>> 
>>>>>> Thanks, that was the class indeed I was looking for to extend.
>>>>> 
>>>>> I created a patch here: http://bugs.freepascal.org/view.php?id=19348
>>>>> 
>>>>> Please review and commit if approved.
>>>> 
>>>> Please rework the patch. I don't want the Error->ErrorFmt, Log->logFmt changes.
>>>> The overloaded versions exist on purpose.
>>> What is the alternative then? Any suggestion?
>> 
>> Never mind. I fixed it myself. Rev 17440.
> 
> I don't like the 'laz_list' exception in pkghandler.pp. I don't want any
> third-party-dependent code in fppkg. And binding on a specific name
> isn't fine either. fppkg should be for general use, if you need
> something special, use an add-in.
> In this case it is probably also possible to come up with another
> solution. (why is it for, anyway?)

As far as I found, the "list" action get's cached in the ExecuteActions and if found the action is not executed, but rather the action is ignored. While perfectly suitable for fppkg which is only run once though and then exits, the GUI version stays active and can run the same actions multiple times.  This makes me think that I should probably create a Laz_ExecuteAction procedure and keep the original procedure in tact. I will create a patch for it.

Regards, Darius