[fpc-devel] Patch for test tstrreal4.pp (Issue 13722)

zeljko zeljko at holobit.net
Tue Sep 7 15:50:16 CEST 2010


On Tuesday 07 September 2010 14:15, Jonas Maebe wrote:
> On 07 Sep 2010, at 14:05, zeljko wrote:
> > Test haven't passed, so I fixed problem (was in currency negative
> > format).
> > Changes:
> > 1.Use clocale under UNIX so various locales can be tested
> > 2.Don't hardcode DecimalSeparator, now it's as it is.
>
> That's not a good idea. Tests for different functionality should be
> separated into different tests, so that the it's clear what's broken
> when the test fails. Simply set decimalseparator to a particular value
> on startup if you wish to test the float->string conversion.

Ok, then I'll create new patch (anyway have to do so because it doesn't pass 
on win32 yet).



More information about the fpc-devel mailing list