[fpc-devel] DOM patch

[Sergei Gorelkin]

Dariusz Mazur wrote:
> Michael Van Canneyt pisze:
>>
>>
>> On Thu, 27 Aug 2009, Michael Van Canneyt wrote:
>>
>>>
>>>
>>> On Thu, 27 Aug 2009, Dariusz Mazur wrote:
>>>
>>>> Hi
>>>> I use DOM  from fcl-xml both for Delphi and FPC development.
>>>> I work with older version, till I notice serious bugs.  Today i've 
>>>> upgrade it from current svn. And problem: Delphi don't compile
>>>> I've made several changes in dom, xmlutil. Diff attached.
>>>>
>>>> As i expect, bugs in new version disappear.
>>>>
>>>>
>>>> It's not change much.
>>>> Can someone review it?
>>>
>>> Reviewed and applied. Thanks !
>>
>> Hm. Something strange with compilation. I reversed the patch, because 
>> xmlutils.pp does not compile with the patch.
>>
>> Strange that I didn't notice the first time I called make ?
>>
>> Could you look at FPC compilation and make a new patch ?
> new  patch attached.
> tested with FPC also, but a cant use testgen
> 
> changed xmlconf
> 1. compilation by Delphi
> 2. added procedure reload
> 
This variable was unsigned for a long time, but recently I changed it to 
signed because it was causing crashes on x86_64 :-)

--- xmlread.pp	(wersja 13601)
+++ xmlread.pp	(kopia robocza)
@@ -925,7 +925,7 @@

  function TXMLDecodingSource.Reload: Boolean;
  var
-  Remainder: PtrInt;
+  Remainder: ptrUInt;
    r, inLeft: Cardinal;
    rslt: Integer;
  begin

Thank you for the patch. I'll modify it a bit and apply this weekend.

Sergei