[fpc-devel] Att: Joost. About bug report 12667
Joost van der Sluis
joost at cnoc.nl
Thu Nov 27 12:08:35 CET 2008
Op zondag 23-11-2008 om 18:31 uur [tijdzone -0300], schreef Luiz Americo
> Joost van der Sluis escreveu:
> > Op zondag 23-11-2008 om 14:48 uur [tijdzone -0300], schreef Luiz Americo
> > Pereira Camara:
> >> Almost all changes were necessary. From 29 changes only 3 were
> >> cosmetical. Very far from "mostly".
> >> "It's easier if you send in patches without any layout-changes."
> > It's just much easier. Remove those three space-fixes, and the rename of
> > Options to LocateOptons from the patch.
> AFAIK is not possible to have a method argument and a property with the
> same name in mode objfpc. Let me know if this changed recently. So the
> is necessary to rename Options to LocateOptions.
You are right, I didn't even thought about that. Sorry.
> I just counted. Please show me more then three changes (4 lines at
> total) with reformatting in a 200 line patch. ALL other changes are
> > That's just very usefull if you write the code with more people using a
> > system like svn. That way everybody is able to review other peoples
> > revisions very quickly.
> Just to know how proceed: by the "way everybody is able to review" and
> "one change at time" approach do you mean:
> http://svn.freepascal.org/cgi-bin/viewvc.cgi?view=rev&revision=12173 or
> http://svn.freepascal.org/cgi-bin/viewvc.cgi?view=rev&revision=12155 ?
I knew I should have added an disclaimer that this would be ideal, and
that I'm not bug-less. ;)
More information about the fpc-devel