[fpc-devel] (patch) optimized 32 to 64 bits multiplication for i386

[Jonas Maebe]

On 03 Nov 2008, at 21:46, Sergei Gorelkin wrote:

> The attached patch implements i386-specific codegeneration for 32 ->  
> 64 bits multiplications, approximately as described in "FPC HowToDo"  
> wiki page.

Thanks!

> I also copied the generic part from tcgaddnode into  
> ti386addnode.second_mul, so that all multiplications are handled in  
> a single procedure. Although there was no absolute need to do that,  
> it makes the code easier to understand.

Could you rewrite it so it does not do that? I have already fixed  
several times in the past code generator bugs which were fixed for one  
architecture but not for another (or not in the generic code) exactly  
due to this sort of duplication.

Thanks,


Jonas