[fpc-devel] please make TField.SetDataset virtual

[Michael Van Canneyt]

On Fri, 30 May 2008, Paul Ishenin wrote:

> Joost van der Sluis wrote:
> > Thanks, committed.
> >   
> Big thanks.
> 
> I have some questions though.
> 
> 1. There is no support for BCD in TField:
> 
>    function GetAsBCD: TBcd; virtual;
>    procedure SetAsBCD(const Value: TBcd); virtual;
>    property AsBCD: TBcd read GetAsBCD write SetAsBCD;
> 
> 
> 2. And few methods have 'word' arguments instead of 'integer':
> delphi:
>    function GetDataSize: Integer; virtual;
>    procedure SetSize(Value: Integer); virtual;
> fpc:
>    procedure SetSize(AValue: Word); virtual;
>    function GetDataSize: Word; virtual;
> 
> I suppose that adding empty methods for BCD support will not hurt while
> changing type of Size methods can break some fpc applications. Is that Size
> incompatibility is by design?

No. It could be that Delphi 3 had an integer argument, but I'm not sure.
The FPC TDataset was originally coded when Delphi was at version 3.

Adding the BCD methods should not hurt, feel free to send a patch.

Michael.