[fpc-devel] Valgrind strscan

[petr.kristan at epos.cz]

On Thu, Apr 10, 2008 at 03:52:42PM +0200, Jonas Maebe wrote:
> 
> On 10 Apr 2008, at 15:32, petr.kristan at epos.cz wrote:
> >On Thu, Apr 10, 2008 at 03:09:34PM +0200, Jonas Maebe wrote:
> >>
> >
> >>It is a false positive by Valgrind. That code intentionally does not
> >>care about reading uninitialised memory from time to time, and treats
> >>that situation correctly. There is similar code in glibc, but  
> >>Valgrind
> >>comes with standard suppression files for glibc which suppress these
> >>false positives. I'm not aware of any suppression files for FPC.
> >
> >I think that this is not false positive. We allocate 1 byte and read  
> >4,
> >report is right. But obviously effective solution do not exists.
> 
> It is a false positive because users read Valgrind reports as lists of  
> error locations in their program (which is indeed how the MemCheck  
> backend of Valgrind is supposed to be used).
> 
> >What about to establish valgind suppressions file in fpc tree?
> >Here is first record.
> >{
> >  Assembler routine always reads 4 bytes alligned by 4 regardles str  
> >length
> >  Memcheck:Addr4
> >  fun:SYSUTILS_STRSCAN$PCHAR$CHAR$$PCHAR
> >}
> 
> If you submit such a file, we can add it to svn.
No problem. Here it is.

Petr

-- 
Ing. Petr Kristan
.
EPOS PRO s.r.o., Bozeny Nemcove 2625, 530 02 Pardubice
tel: +420 466335223    Czech Republic (Eastern Europe) 
fax: +420 466510709
-------------- next part --------------
{
   Assembler routine always reads 4 bytes alligned by 4 regardles str length
   Memcheck:Addr4
   fun:SYSUTILS_STRSCAN$PCHAR$CHAR$$PCHAR
}