[fpc-devel] two changes to fcl 2.0.5

[Jesus Reyes]

--- Michael Van Canneyt <michael at freepascal.org> escribió:

> 
> 
> On Thu, 11 Jan 2007, Jesus Reyes wrote:
> 
> > 
> > --- Michael Van Canneyt <michael at freepascal.org> escribió:
> > 
> > > 
> > > 
> > > On Thu, 11 Jan 2007, Jesus Reyes wrote:
> > > 
> > > > Hi.
> > > > 
> > > > I'm finally tired of two bugs in fcl in 2.0.5, it could be
> > > possible
> > > > that these be made/merged back?.
> > > > 
> > > > 1. TSQLQuery under 2.0.5 stores readonly published property
> > > IndexDefs
> > > > into lazarus lfm file. Lazarus is happy reading back the lfm
> file
> > > if
> > > > it was compiled with 2.0.5 but if it was compiled with 2.1.1
> it
> > > > complains about the readonly property. I can fix that
> manually
> > > > removing the the IndexDefs property from the lfm file, I'm
> tired
> > > of
> > > > it.
> > > > 
> > > > This bug is fixed by this patch:
> > > > Index: sqldb.pp
> > > >
> > >
> ===================================================================
> > > > --- sqldb.pp    (revisión: 5681)
> > > > +++ sqldb.pp    (copia de trabajo)
> > > > @@ -269,7 +269,7 @@
> > > >      property UpdateSQL : TStringlist read FUpdateSQL write
> > > > FUpdateSQL;
> > > >      property InsertSQL : TStringlist read FInsertSQL write
> > > > FInsertSQL;
> > > >      property DeleteSQL : TStringlist read FDeleteSQL write
> > > > FDeleteSQL;
> > > > -    property IndexDefs : TIndexDefs read GetIndexDefs;
> > > > +    property IndexDefs : TIndexDefs read GetIndexDefs stored
> > > false;
> > > >      property Params : TParams read FParams write FParams;
> > > >      property UpdateMode : TUpdateMode read FUpdateMode write
> > > > SetUpdateMode;
> > > >      property UsePrimaryKeyAsKey : boolean read
> > > FUsePrimaryKeyAsKey
> > > > write SetUsePrimaryKeyAsKey;
> > > > 
> > > > 2. I use some png images in my project, every time that I
> need to
> > > do
> > > > changes on the form, a get "Invalid horizontal pixel index
> -1"
> > > error
> > > > message (TImage)" error, this bug is fixed in revision: 5355,
> > > what it
> > > > does?, see:
> > > >
> > >
> >
>
http://www.freepascal.org/cgi-bin/viewcvs.cgi/trunk/fcl/image/fpwritepng.pp?rev=5355&view=diff&r1=5355&r2=5354&p1=trunk/fcl/image/fpwritepng.pp&p2=/trunk/fcl/image/fpwritepng.pp
> > > > 
> > > > What you think?, can this happen?.
> > > 
> > > I don't see the use. We're preparing to release 2.2. 
> > > 
> > > In March we do a code freeze and start the release process.
> > > 
> > > Michael.
> > 
> > offcourse nobody sees the use until they are tired of it like me.
> > 
> > I really don't understand the argument, what are the technical
> reason
> > to not do it?, I don't think too much resources will be spent
> fixing
> > this? (or do you have to start releasing packages with the fix,
> or
> > fixing documentation?, in such case I understand the negative)
> 
> Well,
> 
> As far as I know, there are no releases or snapshots built of
> 2.0.5,
> so why would we update that branch ? 
> 

Are you sure?, then how do you explain this:
http://www.freepascal.org/cgi-bin/viewcvs.cgi/branches/fixes_2_0/?sortby=date&sortdir=down#dirlist
 46 hours, 2 dayes, 3 weeks, it doesn't look freezed to me. 

> It's not a problem to do so, but I don't see the use, as 2.0.5 is
> not
> used by anyone - to my knowledge.
> 
> In fact I'm surprised you use it at all !
> 
> Michael.

If you don't see a problem to do, why not simply do it? 

But, if nobody uses it, why it's being updated?, this simply doesn't
match.

I use 2.1.1 and 2.0.5, Why would I use 2.0.4 when 2.0.5 has fixes? I
though that was the purpose of it, other way I don't see the need for
the branch. 

I'm happily using 2.1.1 until I have to debug in both windows and
linux, that's for what I use 2.0.5 mostly, but sometimes I forget
about it and I keep using it until I made changes and swap machines
and try to load the same project.

That makes me wonder, what do you use for developent?, maybe I'm in
the wrong way. Please share some tricks.

Jesus Reyes A.





	
	
		
___________________________________________________________ 
Do You Yahoo!? 
La mejor conexión a Internet y <b >2GB</b> extra a tu correo por $100 al mes. http://net.yahoo.com.mx