[fpc-devel] Adding constants to defines.inc (windows)

[Florian Klaempfl]

Giulio Bernardi wrote:
> Hi,
> I was playing around with lazarus and I found that solution to a bug
> (6950) is trivial.
> But it needs a constant (SPI_GETFLATMENU) that is not in
> rtl/win/wininc/defines.inc
> (or rtl/win32/wininc/defines.inc for fpc 2.0.x).
> Is it ok if I send a patch to add all SPI* constants (taken from latest
> winuser.h) to defines.inc?

Yes.

> I see that constants are ordered alphabetically. Would you like them
> ordered this way or
> following MS order (by constant value)?.

Feel free to do it how you like ;)

> Also, there are win2000/me or higher constants and winxp or higher
> constants.
> Should they be merged or left separate from the others?
> I mean, something like:
> 
> ..
>     SPI_SETWORKAREA = 47;
> { Windows Me/2000 and higher }
>     SPI_GETACTIVEWINDOWTRACKING = 4096;
> ..
> { Windows XP and higher }
>     SPI_GETBLOCKSENDINPUTRESETS = 4134;

Constants don't hurt so they can be simply added.

> ..
> 
> bye
> Giulio _______________________________________________
> fpc-devel maillist  -  fpc-devel at lists.freepascal.org
> http://lists.freepascal.org/mailman/listinfo/fpc-devel
>