[fpc-devel] fpc 2.0.4 rc2 and mse

[Martin Schreiber]

On Tuesday 18 July 2006 23.27, Joost van der Sluis wrote:
> On Tue, 2006-07-18 at 22:13 +0200, Martin Schreiber wrote:
> > On Tuesday 18 July 2006 19.11, Joost van der Sluis wrote:
> > > > MSE created some patches for fpc 2.0.4 rc1
> > > > to fix some widestring and db issues.
> > > > http://svn.sourceforge.net/viewcvs.cgi/mseide-msegui/trunk/patch_fpc_
> > > >2_0_ 4/
> > > >
> > > > I seems they are not applied to rc2.
> > > >
> > > > Can someone with widestring and db knowledge
> > > > of fpc dev take a look at this?
> > >
> > > The db-files in fpc-2.0.4-rc2 are better up-to-date then the mse-one's.
> > > What's left is irrelevent, or in the fopen case, an ugly hack that
> > > shoudn't be there, imho.
> > >
> > > So for the db-part, nothing has to change.
> > >
> > > Joost
> >
> > Did you fix Mantis 6898 in the meantime?
>
> I didn't but Michael did in the mean time, so it seems.
>
> Well, I can live with that, until I come up with a real solution. I hope
> that the fix doesn't brake any of the db-tests.
>
It seems that Michael used my file for rc1 to build the patch against 
fixes_2_0, so your changes in 4152 (Fix for datasets with a Recordsize which 
will not fit in a word) are lost.
The patch to fix Mantis 6898 against 4023 is:
"
Index: bufdataset.inc
===================================================================
--- bufdataset.inc    (revision 4023) 
+++ bufdataset.inc    (working copy) 
@@ -77,6 +77,7 @@
 var pc : pchar;
 
 begin
+ if fopen then begin 
   FOpen:=False;
   FCurrentRecBuf := FFirstRecBuf;
   SetLength(FUpdateBuffer,0);
@@ -87,6 +88,7 @@
     FreeRecordBuffer(pc);
     end;
   SetLength(FFieldBufPositions,0);
+ end; 
 end;
 
 procedure TBufDataset.InternalFirst;
"

Without this patch tbufdataset writes in coincidental memory areas if it is 
opened/closed several times with and without dbexceptions. It is the case if 
in MSEide one presses the test button in SQL editor while debugging the 
query.
You can imagine what happens later...

Martin