[fpc-devel] patch testreport

[Michael Van Canneyt]

On Sun, 13 Aug 2006, Darius Blaszijk wrote:

> ----- Original Message ----- From: "Michael Van Canneyt"
> <michael at freepascal.org>
> To: "FPC developers' list" <fpc-devel at lists.freepascal.org>
> Sent: Sunday, August 13, 2006 7:10 PM
> Subject: Re: [fpc-devel] patch testreport
> 
> 
> > 
> > 
> > On Sun, 13 Aug 2006, Darius Blaszijk wrote:
> > 
> > > Hi Michael,
> > > 
> > > Thanks, but I have a question.
> > > 
> > > Following the testreport patch, I have also a patch for the
> > > FPCUnitLazIDEIntf
> > > to make use of the plain text output. But I need to put defines
> > > around the new
> > > option, so people with an older FPC version do not get a broken tool.
> > > What
> > > defines would that be?
> > 
> > {$IFNDEF VER2_1}
> > // text output
> > {$ELSE}
> > // XML output.
> > {$ENDIF}
> > 
> > But why would you want to do this ?
> > It seems to me the XML output is easier to use, since it is structured.
> > What is the need to change it ?
> There is no need to change default output, but I find it more easy to watch
> the output of the console app as plain text. I personally don't see a reason
> to use XML as the testapp is purely used to test if nothing is broken after
> changes.

I can see that, but will your patch make plain text the default output for
all lazarus related things ? If there are people out there who count on XML
output, their stuff will be broken.

As Lazarus matures, backwards compatibility with Lazarus becomes more and more 
important :-)


> 
> > I think it's best to discuss this before changing the mechanism...
> Shure. I have added a format option --format=plain. This will output the test
> for the console testapp as plain text. The problem however is that the object
> TPlainResultsWriter will not be available for compilerversions before VER2_1
> (going from the info you gave me), so I need to hide TPlainResultsWriter and
> the options for previous versions. That's all I want to do. Is that ok?

If it's not the default option, this is fine, because the default remains 
backwards compatible...

Michael.

> 
> Darius
> 
> > 
> > Michael.
> > 
> > > 
> > > Darius
> > > 
> > > ----- Original Message ----- From: "Michael Van Canneyt"
> > > <michael at freepascal.org>
> > > To: "FPC developers' list" <fpc-devel at lists.freepascal.org>
> > > Sent: Sunday, August 13, 2006 3:02 PM
> > > Subject: Re: [fpc-devel] patch testreport
> > > 
> > > 
> > > > 
> > > > 
> > > > On Sun, 13 Aug 2006, Darius Blaszijk wrote:
> > > > 
> > > > > Here's a patch that implements the ouput as plain text for
> > > > > FPCunit.
> > > > 
> > > > Thank you. Applied.
> > > > 
> > > > Michael.
> > > > _______________________________________________
> > > > fpc-devel maillist  -  fpc-devel at lists.freepascal.org
> > > > http://lists.freepascal.org/mailman/listinfo/fpc-devel
> > > 
> > > _______________________________________________
> > > fpc-devel maillist  -  fpc-devel at lists.freepascal.org
> > > http://lists.freepascal.org/mailman/listinfo/fpc-devel
> > > 
> > > 
> > _______________________________________________
> > fpc-devel maillist  -  fpc-devel at lists.freepascal.org
> > http://lists.freepascal.org/mailman/listinfo/fpc-devel 
> 
> _______________________________________________
> fpc-devel maillist  -  fpc-devel at lists.freepascal.org
> http://lists.freepascal.org/mailman/listinfo/fpc-devel
>