[fpc-devel] Bug 5049: Record insert at eof in TSQLQuery

Martin Schreiber fpmse at bluewin.ch
Thu Apr 27 17:18:00 CEST 2006


On Wednesday 26 April 2006 00.43, Joost van der Sluis wrote:
> Keep me informed.
> Ik you find something that doesn't sound logical to you, just say so.

dataset.inc:

Procedure TDataset.DoInsertAppend(DoAppend : Boolean);
  procedure DoInsert;
[...]
  if FActiveRecord < FRecordCount-1 then <<<<<< !!!!!!
    begin
    TempBuf := FBuffers[FBuffercount];
    move(FBuffers[FActiveRecord],FBuffers[FActiveRecord+1],
(Fbuffercount-FActiveRecord)*sizeof(FBuffers[0]));
    FBuffers[FActiveRecord]:=TempBuf;
    end
  else if FRecordcount=FBuffercount then
    shiftbuffersbackward              <<<<<<<<<<<<<<<<<<
  else begin
    if FRecordCount>0 then
    inc(FActiveRecord);
  end;

Inserted records are displayed *after* the current record if the current 
record is at end of buffer!

Martin



More information about the fpc-devel mailing list