[fpc-devel] Duplicate code in TDatasource.DistributeEvent implementation

Luiz Américo pascalive at bol.com.br
Sat May 7 22:42:09 CEST 2005


take a look at TDatasource.DistributeEvent implementation (datasource.inc):

With FDatalinks do
     begin
     For I:=0 to Count-1 do
       With TDatalink(Items[i]) do
         If Not VisualControl Then
           DataEvent(Event,Info);
     For I:=0 to Count-1 do
       With TDatalink(Items[i]) do
         If VisualControl Then
           DataEvent(Event,Info);
     end;

Am I missimg something or the check to VisualControl doesnt make sense?
As far as i can see the code below has the same effect

With FDatalinks do
     begin
     For I:=0 to Count-1 do
       With TDatalink(Items[i]) do
         DataEvent(Event,Info);
     end;

Luiz




More information about the fpc-devel mailing list