Why no reaction :-( ? (Re: [fpc-devel]Possible bug?)

Peter Vreman pfv at cooldown.demon.nl
Fri Mar 29 15:30:54 CET 2002

> > Friday, March 29, 2002, 9:05:30 AM, you wrote:
> >
> > MVC> If you send a diff, then I will apply the patch as soon as I have it.
> >
> > Unfortunatelly, I never used GNU diff utility, therefore this will be
> > my first attempt...
> > Original file named pdecsub.pas, after patches (temporarely, for
> > comparing only) named pdecsub.new.
> >
> > command:
> >
> > diff -a pdecsub.pas pdecsub.new
> > output:
> >
> > 1622a1623
> > >               if parast<>nil then
> > 1757a1759
> > >         AktProcDef.parast:=nil;
> This one is correct. I applied it. You can check it out from CVS.

I'm sorry to say it, but the patch was not correct. You didn't test it
using the 'make cycle' command in the compiler dir. This cycle is a check
if the compiler can at least compile itself successful.

The problem with the patch is that aktprocdef is a tprocdef, but when
parsing a procvar it is loaded with a tprocvardef. So you can only access
fields of tabstractprocdef without checking. And parast is a field of
tprocdef only so a check if deftype=procdef is required.

It is now fixed in CVS.

Please regard this message as a hint. We appreciate patches more than bug
reports. Because thanks to your patch the real problem was found much


More information about the fpc-devel mailing list