[fpc-devel] 134 open merge requests - is that normal?
J. Gareth Moreton
gareth at moreton-family.com
Fri Apr 3 11:30:39 CEST 2026
If that's the case Michael, might it be worth merging the Currency
overhaul that pure functions depend on? It may require some testing on
other platforms beforehand, especially i386 since it uses the
floating-point stack (whereas almost all other platforms use general
purpose registers instead), but the testing I've done so far tells me
that it's holding.
Let me know what thresholds I need to reach prior to a merge, besides
remembering to tag them properly!
Kit
On 03/04/2026 09:55, Michael Van Canneyt via fpc-devel wrote:
>
>
> On Fri, 3 Apr 2026, J. Gareth "Kit" Moreton via fpc-devel wrote:
>
>> I run into the same problems since most of my merge requests are
>> focused on optimisation of generated assembly language, which does
>> require a very careful eye to verify, and even then edge cases can
>> sometimes still get through.
>>
>> Recently I've been working on compiler features, namely pure
>> functions and vectorisation. The vectorisation one has a potential
>> code flow problem but I think was necessary due to how SIMD registers
>> work on x86, but as a result is currently sitting in limbo. And pure
>> functions have been sitting around for 2 years, and developed over 2
>> years before that! I would like it merged into the trunk so I can
>> start development of the next stage - the ability to assign the
>> results of pure functions to constants - but it itself is waiting on
>> a merge request that overhauls the Currency type to be more
>> internally consistent in the compiler so constant propagation works
>> properly on it.
>>
>> As much as I want to say "Just trust me, bro" and have them merged,
>> that tends not to fly in software development circles!! Granted, I do
>> wonder if, with some things, it's worth merging them and then fixing
>> the teething problems as they arise.
>
> That's exactly what I mean by 'can I judge them'.
>
> Given that it is a one-click action to revert a merge, it is of course
> tempting to lower the treshold...
>
> Michael.
>
> _______________________________________________
> fpc-devel maillist - fpc-devel at lists.freepascal.org
> https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
--
This email has been checked for viruses by Avast antivirus software.
www.avast.com
More information about the fpc-devel
mailing list