[fpc-devel] heap.inc evo when
Michael Van Canneyt
michael at freepascal.org
Wed Apr 16 12:00:39 CEST 2025
On Wed, 16 Apr 2025, Florian Klämpfl via fpc-devel wrote:
> On 15.04.25 22:52, runewalsh via fpc-devel wrote:
>> What’s the position on MR !694? Person with the yellow avatar mentioned
>> in https://gitlab.com/freepascal.org/fpc/source/-/
>> commit/922457e5b58d76a13ff706f9220d9d6350631930#note_2390656703 there
>> was some discussion somewhere, and that’s all.
>
> Our main issue is that nobody really feels capable of reviewing it :(
> The initial contributors of the heap manager are basically gone and
> nobody else is really that deep into this code to do a review.
Since Runewalsh is deep in it, clearly we're not off worse if we change it :-)
So, in order to progress: we'll throw it in the wild to be field-tested.
So I propose the following: I will add the new heap manager in a new file.
I'll include the old and the new one with an IFDEF, activated by default so it will be tested.
In case of trouble the old one can be reactivated quickly using a simple recompile of the RTL.
If after 3(4,5,6) months we don't get bugreports, we remove the old one
unless Runewalsh fixes the bugs.
Unless there are objections, I'll implement it this weekend.
Michael.
More information about the fpc-devel
mailing list