[fpc-devel] Division nodes

[J. Gareth Moreton]

I made a merge request that removes the comparison against -1. 
x86_64-win64 and i386-win32 pass without any regressions, so the reason 
behind the change still eludes me.  Maybe my fix for #39646 removes the 
need for it?

https://gitlab.com/freepascal.org/fpc/source/-/merge_requests/418

Kit

On 11/05/2023 23:04, J. Gareth Moreton via fpc-devel wrote:
> Fair enough, but I would like an explanation as to why it's necessary, 
> because the reason for testing -1 in particular is very unclear, and I 
> wonder if there's a known misbehaviour with a particular division 
> function with -1.
>
> Kit
>
> On 11/05/2023 21:27, Wayne Sherman wrote:
>> On Thu, May 11, 2023 at 11:42 AM J. Gareth Moreton wrote:
>>> This is the code block in question (ncnv.pas, starting at line 3397)
>> The git "blame" function shows who last made changes:
>> https://gitlab.com/freepascal.org/fpc/source/-/blame/main/compiler/ncnv.pas?page=4#L3396 
>>
>>
>> Most of that code was added 2 years ago in this commit:
>> https://gitlab.com/freepascal.org/fpc/source/-/commit/ea11517d27fa00f40b626e47213f0caa8832d155 
>>
>>
> _______________________________________________
> fpc-devel maillist  -  fpc-devel at lists.freepascal.org
> https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
>