[fpc-devel] duplicate internal error numbers

[Marģers .]

----- Reply to message -----
Subject: Re: [fpc-devel] duplicate internal error numbers
Date: trešd., 7 okt. 2020, 14:16
From:  Jonas Maebe via fpc-devel <fpc-devel at lists.freepascal.org>
To:  <fpc-devel at lists.freepascal.org>
> On 07/10/2020 13:02, Marģers . via fpc-devel wrote:
> > found total 4300+
> > 1001 error number has to be changed to make all error number unique
> >
> > as there are so huge number of changes to make i have question
> > 1) would it be desirable to change all (or most) duplicate error 
> > numbers in one single big patch?
> > 2) selective amount of changes in multiple patches?
> > 3) leave it as is? not broken don't fix or do nothing is a choice.

> How many of these are part of different code generators? We only support
> one architecture per compiler binary _and_ code generators for new
> architectures often start as (partial) copies of existing code
> generators, so it's normal that they have a lot of duplicate internal
> errors, but it doesn't matter.

> OTOH, I'm sure there are also still duplicates in generic code and
> within single architectures, but to find those you have to look
> exclusively at the generic files in combination with those for a single
> architecture (which may be in multiple directories, e.g. compiler/x86
> and compiler/i386 for the i386 target).

It's still plenty potential duplicates. Got 339 unique cases to investigate. A lot manual labor. As i understand that automated changes are not welcomed.