[fpc-devel] TRegistry and Unicode

[Bart]

On Mon, Mar 11, 2019 at 12:37 AM Michael Van Canneyt
<michael at freepascal.org> wrote:

> What's the problem ?
The problem is that you make me feel that evreything I do or think of is wrong.
Most likely this would not be the case if we were in the same room and
talked about it.

Another practical problem is that we (as in the participants in this
thread) still have not decided which way to go with this.
Do we want overloads for all public/protected TRegistry methods that
use UnicodeString or Utf8String, or both, or none of that?

> For organizational reasons, I personally prefer a single patch that
> implements what I consider correct, and not a series of incremental
> patches each addressing part of the problem.

I understand that, but ATM it is almos undo-able for me to work on the registry.
Every time I work on one issue I have to revert all chages I made for
other issues.
This becomes very cumbersome, very fast.
If I start writing the "all including" unicode patch for TRegistry it
will include unrelated fixes, otherwise I cannot test what I'm doing.

IMO, since this is trunk, patches need not be perfect in order to be
apllied, they just need to be better than the old situation.
Of course judging that is up to the devels.
Apply and then gradualy better the code based on feedback.

Once "good enough" merge all fixes to 3.2 branch.

Another problem for me is the not-windows part of the registry.
E.g. TRegIniFile in the XML implementation is totally broken for at
least 6 years.
Nobody has posted a bugreport about that in that period.

Now that comes to bite me in the *** when I fix some bugs in the
windows implementation of TRegIniFile.
Fixing the XML implementation of that is currently beyond my capabilities.
(In my personal opinion I'ld get rid of the not-windows implementation
of TRegInifile. Yes it is backwards incompatible, but there cannot be
users out there using it, otherwise bugreports would have been filed.)

> So, please carry on. Someone will eventually apply the patches!

I will try to.

B.t.w. Michael: you unassigned yourself from
https://bugs.freepascal.org/view.php?id=35213 and
https://bugs.freepascal.org/view.php?id=35022 , but you forgot to
change status to either new, acknowledged or confirmed. Now the issues
are still "blue" in the bugtracker, so every other devel will think
the issue is assigned to some other devel.
Can you please adjust the status of the issues?


-- 
Bart