[fpc-devel] [Suggestion] Enumeration range-check intrinsic

Sven Barth pascaldragon at googlemail.com
Tue Jul 9 11:12:45 CEST 2019


J. Gareth Moreton <gareth at moreton-family.com> schrieb am Di., 9. Juli 2019,
08:20:

> Apologies - I see now... I used them with "with" without even thinking
> about it!  I've made the changes as requested. Admittedly it's quite
> hard for me to remove spaces from either side of operators because
> that's something I learnt from my early days in Turbo Pascal and to not
> have spaces (and all types and variables being lowercase) feels very
> C-like.  But hey, rules are rules... or guidelines!
>

I know the feeling. But when in Rome...

Is the new AS-IS-enum-08 patch any better?
>

Better (though are still some " = " around :P ), but it seems you missed
tasnode.pass_1?
Also the typenames (TOrdDef, TEnumDef) should be lowercase as well as the
local variables.

Regards,
Sven

>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freepascal.org/pipermail/fpc-devel/attachments/20190709/aef68268/attachment.html>


More information about the fpc-devel mailing list