[fpc-devel] [patch] regex.pp with out parameters

[Joost van der Sluis]

Op vrijdag 27-03-2009 om 14:07 uur [tijdzone +0200], schreef Graeme
Geldenhuys:
> On Fri, Mar 27, 2009 at 1:57 PM, Joost van der Sluis <joost at cnoc.nl> wrote:
> >>
> >> The patch simply changes the 'var' parameters to 'out' parameters.
> >
> > It surely fixes the warning, but not the problem? Doesn't 'out' generate
> > faster code in this case? And shoudn't the error be always set? To 0 if
> > no error occured or something else if there really is an error?
> 
> 
> Well, I was simply working on the warning issue.  I hate compiler
> warnings or hints in my code. :-)  Looking at the Parse() method, it
> never reads the parameters, it only ever sets them. Hence the idea of
> using the 'out' parameters.

Ok, thanks. Comitted in revision 12969.

Joost