[fpc-devel] Re: merge rev12290

Felipe Monteiro de Carvalho felipemonteiro.carvalho at gmail.com
Mon Dec 8 13:17:11 CET 2008


On Mon, Dec 8, 2008 at 10:04 AM, Joost van der Sluis <joost at cnoc.nl> wrote:
> Can you explain what the results are when we don't merge the fix? And
> vice-versa?

For the test case or as a whole?

The test case will crash without the fix.

As a whole the Lazarus Windows CE interface will be unable to
automatically detect if the current language works from left-to-right
or in the opposite direction. It is also impossible to use the
GetLanguageIDs routine under Windows CE because it crashes the
application.

The change is rather trivial and therefore very easy to verify it's correctness.

I personally don't use right-to-left texts at the moment, but the bug
in this routine makes me need to add an ifdef in the LCL so that the
routine isn't called for Windows CE. I would prefer not having the
ifdef. Any user software using this routine will also face problems (a
crash) when being compiled for Windows CE.

-- 
Felipe Monteiro de Carvalho



More information about the fpc-devel mailing list