[fpc-devel] Duplicate code in TDatasource.DistributeEvent implementation

Luiz Américo pascalive at bol.com.br
Mon May 9 02:45:27 CEST 2005


Michael Van Canneyt wrote:
> 
> On Sat, 7 May 2005, Luiz Américo wrote:
> 
> 
> No. First non visual components (such as detail datasets, lookup datasets) 
> must get their event, and only then visual controls get an event. 
> 
> The double loop is intentional.
> 

Thank you.
Now I can see the intention.

It seens that this procedure is called quite often.
One approach to optimize could be inserting the items in FDataLinks in 
the appropriate order (Non visual first, visual in the end) and doing a 
simple loop without checks in DistributeEvent.
This would be done inside RegisterDataLink with a simple and safe alghoritm.

If you agree with the cited approach i can send the patch.

Luiz




More information about the fpc-devel mailing list