[Pas2js] First impressions and Queries

[Michael Van Canneyt]

On Thu, 25 Jan 2018, Michael Van Canneyt wrote:

>
>
> On Thu, 25 Jan 2018, Mattias Gaertner wrote:
>
>> On Thu, 25 Jan 2018 09:12:33 +0100
>> Mattias Gaertner <nc-gaertnma at netcologne.de> wrote:
>>
>>> On Wed, 24 Jan 2018 21:58:04 +0000
>>> C Western <l at c-m-w.me.uk> wrote:
>>> 
>>> >[...]
>>> > 1. The .map files produced always seem to be corrupt - they always 
> begin:
>>> > 
>>> > )]}
>>> > {"version":3,"file":"ar.js","sources":["/home....
>>> > 
>>> > which doesn't look right. Am I doing something wrong? Fortunately the 
>>> > code produced is sufficiently close to the original that debugging with 
>>> > the firefox developer tools was straightforward. 
>>> 
>>> If you mean the )]}, this avoids potential XSSI attacks and is
>>> recommended in the specs:
>>> 
> https://docs.google.com/document/d/1U1RGAehQwRypUTovF1KRlpiOFze0b-_2gc6fAH0KY0k/edit#heading=h.h7yy76c5il9v
>>> 
>>> In what browser does it not work?
>>
>> I tested in Firefox (again) and indeed it bails out. I will make this
>> optional.
>
> Are you not missing a ' ?
> )]}'
>
> Maybe firefox checks for the exact string as specified in the docs ?

Seems my hunch was maybe right:
https://github.com/nodeca/mincer/issues/159

Michael.