<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jan 29, 2015 at 7:26 PM, Michael Van Canneyt <span dir="ltr"><<a href="mailto:michael@freepascal.org" target="_blank">michael@freepascal.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class=""><br>
<br>
On Thu, 29 Jan 2015, silvioprog wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Hello,<br>
<br>
Please see this patch in attached. Can I send it to bugtracker?<br>
</blockquote>
<br></span>
I don't see the point. Why do you need this ?</blockquote></div><div><br></div><div><div>Yes, after a while I saw that my patch seems redundant. But please notice this code below:</div><div><br></div><div>function TFCGIRequest.ProcessFCGIRecord(AFCGIRecord: PFCGI_Header): boolean;</div><div>...</div><div>                        else</div><div>                          begin</div><div>                          if not assigned(FCGIParams) then</div><div>                            FCGIParams := TStringList.Create;</div><div>                          GetNameValuePairsFromContentRecord(PFCGI_ContentRecord(AFCGIRecord),FCGIParams);</div><div>                          end;</div><div><br></div><div>It seems to offer the programmer to create an own cgiparams. Is this "if" just to create this field when the request need to use it?</div><div><br></div><div>What do you think about to create the FCGIParams field in the create of the TFCGIRequest class and remove the "if" from the ProcessFCGIRecord method?</div></div><div><br></div><div>I think that the ProcessFCGIRecord method is more triggered than the constructor of the TFCGIRequest class.</div><div><br></div>-- <br><div class="gmail_signature">Silvio Clécio<br>My public projects - <a href="http://github.com/silvioprog" target="_blank">github.com/silvioprog</a></div>
</div></div>