[fpc-pascal] Don't understand Zipper.DoEndOfFile/UnZipper.DoEndOfFile

[Reinier Olislagers]

On 15-8-2012 14:24, Michael Van Canneyt wrote:
> 
> 
> On Wed, 15 Aug 2012, Reinier Olislagers wrote:
> 
>> On 15-8-2012 13:48, Michael Van Canneyt wrote:
>>> On Wed, 15 Aug 2012, Reinier Olislagers wrote:
>>>
>>>> I've been working on documenting the Zipper/Unzipper classes:
>>>> packages\paszlib\src\zipper.pp
>>>> Now looking at the protected procedure TZipper/TUnzipper.DoEndOfFile
>>>>
>>>> They apparently update compression percentage statistics and call a
>>>> user
>>>> defined callback (if any, defined in OnEndOfFile)
>>>>
>>>> I don't understand though by whom/if they are called? A grep through
>>>> the
>>>> source code showed nothing referencing it.
>>>
>>> The calls to these routines must have fallen out during some
>>> refactoring. They should be called when the zip/unzip operation is done.
>> Ok, just for confirmation: done after each file in the list - as
>> oppposed to the zip/unzip operation on the entire zip file, right?
> 
> Yes.
> 
>> I'll have a look through the history to see if I can find it and write
>> up a patch.
> 
> That would be nice :)
Nice, separated hot, fresh patches ;)
Patch for executing DoEndFile/hooking up OnEndOfFile: 22651
Basic test of zip/unzip functionality for compiler tests: 22648

Thanks,
Reinier