<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><br id="lineBreakAtBeginningOfMessage"><div><br><blockquote type="cite"><div>Am 18.04.2025 um 15:44 schrieb Michael Van Canneyt via fpc-devel <fpc-devel@lists.freepascal.org>:</div><br class="Apple-interchange-newline"><div><meta charset="UTF-8"><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">On Fri, 18 Apr 2025, Florian Klämpfl via fpc-devel wrote:</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br><br><blockquote type="cite">Am 18.04.2025 um 15:10 schrieb Michael Van Canneyt via fpc-devel <fpc-devel@lists.freepascal.org>:<br><br><br><br>On Fri, 18 Apr 2025, Michael Van Canneyt via fpc-devel wrote:<br><br><blockquote type="cite"><br><br>On Fri, 18 Apr 2025, Florian Klämpfl via fpc-devel wrote:<br><br><blockquote type="cite"><blockquote type="cite">Am 18.04.2025 um 14:07 schrieb Michael Van Canneyt via fpc-devel <fpc-devel@lists.freepascal.org>:<br>On Fri, 18 Apr 2025, Florian Klämpfl via fpc-devel wrote:<br><blockquote type="cite"><blockquote type="cite">Am 16.04.2025 um 12:00 schrieb Michael Van Canneyt via fpc-devel <fpc-devel@lists.freepascal.org>:<br>On Wed, 16 Apr 2025, Florian Klämpfl via fpc-devel wrote:<br><blockquote type="cite">On 15.04.25 22:52, runewalsh via fpc-devel wrote:<br><blockquote type="cite">What’s the position on MR !694? Person with the yellow avatar mentioned in https://gitlab.com/freepascal.org/fpc/source/-/ commit/922457e5b58d76a13ff706f9220d9d6350631930#note_2390656703 there was some discussion somewhere, and that’s all.<br></blockquote>Our main issue is that nobody really feels capable of reviewing it :( The initial contributors of the heap manager are basically gone and nobody else is really that deep into this code to do a review.<br></blockquote>Since Runewalsh is deep in it, clearly we're not off worse if we change it :-)<br>So, in order to progress: we'll throw it in the wild to be field-tested.<br>So I propose the following: I will add the new heap manager in a new file.<br></blockquote>Please do it in a way which preserves line history: copy heap.inc to oldheap.inc, add and commit it. Then accept the merge request. Add ifdefs. So heap.inc keeps line history making debugging in the future easier.<br></blockquote>I intended to do it more or less so, yes.<br></blockquote>The way you did it, line history is broken :(<br></blockquote><br>Huh ? This makes no sense to me.<br><br>What's the point of having "git mv" if it does not preserve history?<br></blockquote><br>I checked, I can do "git log" on both files, and I get the full history (for<br>oldheap.inc you need to add --follow to get it)<br><br>Is this not what you wanted ?<br></blockquote><br>When I do git blame I get:<br><br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 1) {<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 2) This file is part of the Free Pascal run time library.<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 3) Copyright (c) 1999-2000 by the Free Pascal development team.<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 4)<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 5) functions for heap management in the data segment<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 6)<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 7) See the file COPYING.FPC, included in this distribution,<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 8) for details about the copyright.<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 9)<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 10) This program is distributed in the hope that it will be useful,<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 11) but WITHOUT ANY WARRANTY; without even the implied warranty of<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 12) MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 13)<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 14) **********************************************************************}<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 15)<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 16) {****************************************************************************}<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 17) { Do not use standard memory manager }<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 18) { $define HAS_MEMORYMANAGER}<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 19)<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 20) { Memory manager }<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 21) {$if not defined(FPC_NO_DEFAULT_MEMORYMANAGER)}<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 22) const<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 23) MemoryManager: TMemoryManager = (<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 24) NeedLock: false; // Obsolete<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 25) GetMem: {$ifndef FPC_NO_DEFAULT_HEAP}@SysGetMem{$else}nil{$endif};<br>c8bf474d6d0 (Michaël Van Canneyt 2025-04-18 14:44:24 +0200 26) FreeMem: {$ifndef FPC_NO_DEFAULT_HEAP}@SysFreeMem{$e<br><br>? Does it work for you?<br></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">No, I get the same.</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">But I only checked the workings of git log.</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">But now I understand correctly what you meant by "line history" : the "git blame"</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">output. I implicitly assumed you meant 'linear history' :-(</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"></div></blockquote><div><br></div>Yes :) It often helps to understand code. But I think I can fix it without rewriting git history. Though that one of oldheap.inc will be gone but it doesn’t matter for oldheap.inc imo.</div><div><br><blockquote type="cite"><div><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">My apologies, if I had correctly understood, I would have done exactly as you said :/</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">Michael._______________________________________________</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">fpc-devel maillist - </span><a href="mailto:fpc-devel@lists.freepascal.org" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">fpc-devel@lists.freepascal.org</a><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><a href="https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel</a></div></blockquote></div><br></body></html>