<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">25.12.2023 16:51, Maxim Ganetsky via
fpc-devel пишет:<br>
</div>
<blockquote type="cite"
cite="mid:db9fd3a5-e493-476a-a1ae-df73875163a9@narod.ru">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div class="moz-cite-prefix">25.12.2023 13:01, Michael Van Canneyt
via fpc-devel пишет:<br>
</div>
<blockquote type="cite"
cite="mid:e52382c0-753b-97-a613-5ab2cdf4b7ce@freepascal.org"> <br>
<br>
On Sun, 24 Dec 2023, Maxim Ganetsky via fpc-devel wrote: <br>
<br>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">As far as I know, Mattias is busy
with it and has at least fixed the tests ? <br>
</blockquote>
<br>
I see the commit by Mattias now, but it does not affect
config file created by `make install`, because the
following duplicated code is used for creating config
files when running `make install`: <br>
<br>
<br>
</blockquote>
</blockquote>
<a class="moz-txt-link-freetext"
href="https://gitlab.com/freepascal.org/fpc/pas2js/-/blob/main/fpmake.pp?ref_type=heads#L20"
moz-do-not-send="true">https://gitlab.com/freepascal.org/fpc/pas2js/-/blob/main/fpmake.pp?ref_type=heads#L20</a>
<br>
<blockquote type="cite"> <br>
I updated the config file writing. 2 files are written now.
My local tests are all OK. <br>
</blockquote>
<br>
Please elaborate. I just updated FPC and Pas2Js, nothing
changed in behavior. Where is the commit? <br>
</blockquote>
<br>
Sorry, forgot to push. fpmake.pp in pas2js repo. </blockquote>
<p>OK, now config contents have changed, but Codetools tests still
fail with the same error (pas2js system unit not found). Config
contents:</p>
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap"><font face="monospace">Contents
of /usr/local/bin/pas2js.cfg:</font></span></div>
<code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">#</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap"># Minimal config file for
pas2js compiler</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">#</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap"># -d is the same as #DEFINE</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap"># -u is the same as #UNDEF</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">#</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap"># Write always a nice logo
;)</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">-l</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap"><br>
</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap"># Display Warnings, Notes
and Hints</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">-vwnh</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap"># If you don't want so much
verbosity use</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">#-vw</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block"></code><code
data-testid="job-log-content" class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">#IFDEF
FPC_SUBTARGET_NAMESPACED</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block"></code><code
data-testid="job-log-content" class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">-Fu$CfgDir../lib/fpc/3.3.1/pas2js/*/namespaced</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">-Fi$CfgDir../lib/fpc/3.3.1/pas2js/*/src</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">-Fu$CfgDir../lib/fpc/3.3.1/pas2js/rtl/src</span></div>
</code></blockquote>
<p>I see that there are missing directory separators after $CfgDir,
maybe this is the reason?</p>
<p>Also probably it would be worth to consider removing code
duplication between createconfig.pp and fpmake.pp in regards of
config file generation.<br>
</p>
<blockquote type="cite"
cite="mid:db9fd3a5-e493-476a-a1ae-df73875163a9@narod.ru"><code
data-testid="job-log-content" class="job-log gl-display-block">
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">#else</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">-Fu$CfgDir../lib/fpc/3.3.1/pas2js/*/src</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">#endif</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap"><br>
</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">#IFDEF nodejs</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">-Jirtl.js</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">#ENDIF</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap"><br>
</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap"># Put all generated
JavaScript into one file</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">-Jc</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap"><br>
</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap"># end.</span></div>
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap"><br>
</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block">
<div class="js-log-line job-log-line"><span
class="gl-white-space-pre-wrap">Contents of
/usr/local/bin/pas2js-namespaced.cfg:</span></div>
</code><code data-testid="job-log-content"
class="job-log gl-display-block"><span
class="gl-white-space-pre-wrap">-dUNICODERTL</span></code></blockquote>
--
<pre class="moz-signature" cols="72">Best regards,
Maxim Ganetsky <a class="moz-txt-link-freetext" href="mailto:ganmax@narod.ru">mailto:ganmax@narod.ru</a></pre>
</body>
</html>