<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 20 Mar 2012, at 23:43, peter green wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Monaco; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="font-family: monospace; ">I attatch a patch which adds support for armhf to freepascal.<br></span></span></blockquote><div><br></div><div>Thanks!</div><br><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Monaco; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="font-family: monospace; ">Armhf reffers to arm with the VFP hardfloat variant of EABI. The defaults are setup to<br>be suitable for debian armhf (armv7 vfpv3_d16).<br></span></span></blockquote></div><br><div>Are they Debian-specific? Adding distribution-specific settings to the compiler is something that should be very much avoided.</div><div><br></div><div>Some other remarks:</div><div>* please split unrelated parts into separate patches (such as making the internalerror in ninl.pas unique)</div><div>* please create bug reports for those individual patches and attach them there, it makes them easier to track than on a mailing list</div><div>* some stylistic remarks (there may be more, I just quickly glanced over the patch):</div><div><br></div><div><div>+ if ((target_info.abi=abi_eabi) or (target_info.abi=abi_eabihf)) and</div></div><div><br></div><div>-> change into an in-statement (and as mentioned before, please do not put multiple if-conditions on the same line except if they are really short like two boolean variables)</div><div><br></div><div><div>+ if target_info.abi = abi_eabihf then def_system_macro('FPC_ABI_EABI');</div></div><div><br></div><div>-> Put the then-part on a separate line</div><div><br></div><div><div>+ end else begin</div></div><div><br></div><div>-> this should be</div><div><br></div><div> end</div><div>else</div><div> begin</div><div><br></div><div><br></div><div>Jonas</div></body></html>