<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=x-mac-ce" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Joost,<br>
thanks for reply<br>
<blockquote cite="mid:1297861198.24582.23.camel@wsjoost.cnoc.lan"
type="cite">
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">4. <a class="moz-txt-link-freetext" href="http://bugs.freepascal.org/view.php?id=14944">http://bugs.freepascal.org/view.php?id=14944</a>
This fix adds support for transactions in ODBCConnection
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre wrap=""><!---->
Adding transactions so close to a release is not a good idea, imho. It
could be added in trunk, though.</pre>
</blockquote>
ok, no objections from me side<br>
only to explain: ODBC works by default in auto-commit mode, and this
behavior is not affected by fix so all remains as is.<br>
only when you supply to TODBCConnection.Params: 'Autocommit=false' or
'AutoCommit=0' you will switch to manual commit.<br>
without this all works as before.<br>
<br>
<blockquote cite="mid:1297861198.24582.23.camel@wsjoost.cnoc.lan"
type="cite">
<pre wrap=""> But first run the testsuite with this
patch for at least mysql/mssql and firebird using odbc.
</pre>
</blockquote>
;-) please, no<br>
<br>
<blockquote cite="mid:1297861198.24582.23.camel@wsjoost.cnoc.lan"
type="cite">
<pre wrap=""></pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">5. <a class="moz-txt-link-freetext" href="http://bugs.freepascal.org/view.php?id=16885">http://bugs.freepascal.org/view.php?id=16885</a>
This fix adds missing TOracleConnection.RowsAffected method
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre wrap=""><!---->
A regression-test has to be performed before this can be comitted.
(Needs an oracle setup)
</pre>
</blockquote>
Why do you think, that this patch can lead to problems, ATM
RowsAffected is not implemented, so it always returns -1.<br>
So nobody can use / rely on this value.<br>
So I think, that provide some (untested) solution is better than
nothing ... and we can wait for users feedback<br>
(I do not have Oracle instaled, so I can not help, test)<br>
<br>
<blockquote cite="mid:1297861198.24582.23.camel@wsjoost.cnoc.lan"
type="cite">
<pre wrap=""></pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">6. <a class="moz-txt-link-freetext" href="http://bugs.freepascal.org/view.php?id=18699">http://bugs.freepascal.org/view.php?id=18699</a>
This fixes Dialect 1 case
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre wrap=""><!---->
The question in the bug-report has to be answered.
</pre>
</blockquote>
answered<br>
<br>
<blockquote cite="mid:1297861198.24582.23.camel@wsjoost.cnoc.lan"
type="cite">
<pre wrap="">
So even 4,5 and 6 are not that easy. (If they were, they were already
applied)
</pre>
</blockquote>
;-) ok<br>
<br>
Thanks<br>
Laco.<br>
<br>
</body>
</html>