<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=x-mac-ce" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
<br>
<blockquote cite="mid:1297855717.24582.18.camel@wsjoost.cnoc.lan"
type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">They all need improvement or a better review or testcases or break
backwards compatibility.
</pre>
</blockquote>
<pre wrap="">The BIGINT or NCHAR stuff not, I would think ?
I'll have a look.
</pre>
</blockquote>
<pre wrap=""><!---->
BIGINT leads to a backwards compatibility issue with largeint not being
recognized anymore. (not a real problem I think, but it must be
documented in user-changes)</pre>
</blockquote>
then we can leave "largeint" and add "bigint" this will be safe in all
aspects. And largeint can be dropped later (as obsolete, non-standard).<br>
<br>
<blockquote cite="mid:1297855717.24582.18.camel@wsjoost.cnoc.lan"
type="cite">
<pre wrap=""> And I think to fix this a revision has to be
reverted, not committed? Which leads to a new issue: we need to add a
test that test for the problem introduced with the revision being
reverted. (ie: recognition of fieldtypes when the first record is NULL)
</pre>
</blockquote>
yes this problem was revealed, but does not affect fix as I wrote in
bug tracker we must always rely on sqlite3_column_decltype()<br>
and only when no useful information will be available then use as
workaround (or hack) sqlite3_column_type()<br>
<br>
<blockquote cite="mid:1297855717.24582.18.camel@wsjoost.cnoc.lan"
type="cite">
<pre wrap="">
The nchar stuff doesn't have tests.</pre>
</blockquote>
yes it is true, but they can be added later ... but NCHAR is not
supported by all databases so it must be implemented carefully<br>
<br>
<blockquote cite="mid:1297855717.24582.18.camel@wsjoost.cnoc.lan"
type="cite">
<pre wrap=""> I don't even know if ftWideString
and such are working at all.</pre>
</blockquote>
for me it works ... and as TWideStringField is descendant of
TStringField (which have tests), there is big chance, that it will work<br>
<br>
<blockquote cite="mid:1297855717.24582.18.camel@wsjoost.cnoc.lan"
type="cite">
<pre wrap=""> The basic tests for these types have to be
added.
</pre>
</blockquote>
if some patches are problematic, then leave it for future ... but
please comment my list and let me know if I can do something to help.<br>
IMHO at least points 4,5,6 are safe.<br>
<br>
Thanks<br>
Laco.<br>
<br>
</body>
</html>