<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head>
<title></title>
<meta http-equiv="content-type" content="text/html;charset=utf-8"/>
<meta http-equiv="Content-Style-Type" content="text/css"/>
</head>
<body>
<div align="left"><font face="Arial" size="2"><span style="font-size:10pt">On 1 Jul 2007 at 20:20, Tomas Hajny wrote:</span></font></div>
<div align="left"><font face="Arial" size="2"><span style="font-size:10pt"><br />
</span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> First, I don't see why using the helper variable </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> should be worse than the newly proposed version. </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> Actually, I even believe that the optimizer might </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> be able to get rid of it if not needed (i.e. if </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> more efficient - on the other hand, using the </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> helper variable may be better because the </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> addition of length(doscmd) to argv0len is </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> performed only once rather than twice).</span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt"><br />
</span></font></div>
<div align="left"><font face="Arial" size="2"><span style="font-size:10pt">The purpose of this cleanup is for readability of source, and I think</span></font></div>
<div align="left"><font face="Arial" size="2"><span style="font-size:10pt">that a minor number of variable grows it.</span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt"><br />
</span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> Second, as far as I can see, the proposed code </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> isn't semantically identical to the original one </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> (the terminating #0 is placed 1 byte earlier). So </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> unless there's a reason to change it (that's what </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> I asked about in the previous e-mail), I wouldn't </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> touch it. If you think that it needs to be </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> changed, please, provide clarification why it's </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> so and why the current version is wrong.</span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt"><br />
</span></font></div>
<div align="left"><font face="Arial" size="2"><span style="font-size:10pt">I was not clear in previous e-mail, the focus of </span></font><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">r7012 is just</span></font><font face="Arial" size="2"><span style="font-size:10pt"> that the
</span></font><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">terminating #0 must be placed 1 byte earlier, by freezing the position with
the variable cmdlen and skipping the inc(argv0len) which causes an off by
one. </span></font><font face="Arial" size="2"><span style="font-size:10pt">My patch proposes a more simple way to obtain that.</span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt"><br />
</span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> I was indeed on holiday at that time. However, I </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> can't test GO32v2 patches properly anyway at the </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> moment, so I decided not to apply them any longer </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> unless they are really obvious and I can reliably </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> foresee their effects. I'm sorry about that - </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> maybe someone else (like Pierre) can check and </span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt">> apply them if appropriate.</span></font></div>
<div align="left"><font face="Arial" color="#7f0000" size="2"><span style="font-size:10pt"><br />
</span></font></div>
<div align="left"><font face="Arial" size="2"><span style="font-size:10pt">I take effect of that, but in fact Pierre and others never answer to my
segnalations, especially for those beyond the Go32v2 specific like the
threads 'Nasm under FPC' and 'Question about assembler generators'.</span></font></div>
</body>
</html>