[fpc-devel] Less global variables

Hans-Peter Diettrich DrDiettrich1 at aol.com
Sun Oct 10 00:32:32 CEST 2010


Florian Klämpfl schrieb:

>> Now I hope that this patch will be applied to the trunk soon.
> 
> No. It's a mess and I won't sort it out.

What do you feel a need for sorting out?

> Not to mention the indentation
> style not following the style used in the surrounding code,

The new or changed parts can be identified by their different naming
style, more Pascal like, with not everything lowercase. The same for
indentation, where different styles are already found in the source
code. Refactoring, and maintenance in general, is much easier with more
condensed code, without excessive indentation and almost-empty lines.

Provided that there exists a defined indentation style, a formatter tool
can transform any code into the defined format. In so far I cannot
understand according complaints :-(

> comments I made about the older patch are ignored,

Which in detail do you mean?

> strange changes without any
> comment like in cfidwarf etc.

Ooops, cfidwarf should not have been affected. I guess it's due to the
different base revision in my merge :-(

DoDi




More information about the fpc-devel mailing list