[fpc-devel] [PATCH] patch for zipper.pp

[Micha Nelissen]

Andrew Haines wrote:
> procedure TForm1. at UnZipCustomOutput(Sender: TObject; var AStream:
>             TStream; AItem: TFullZipFileEntry; AClosing: Boolean);
> begin
>   if AClosing = False then
>   begin
>     AStream := TMemoryStream.Create;
>   end

Do you mind if I say I think this is a very weird event handler?

What is the behaviour? How many times is it called? What does AClosing 
mean? How do I know I don't have a memory leak?

Why an event handler and not a property? A CustomStream property where 
non-nil means use this stream, if nil then default old behaviour e.g.

Micha