[fpc-devel] correct usage of fpstat() inside FileAge() function

[Graeme Geldenhuys]

Hi,

This is the implementation of FileAge() under FPC 2.6.0 (the upcoming release)

---------------------------------------
Function FileAge (Const FileName : String): Longint;

Var Info : Stat;

begin
  If  (fpstat (pointer(FileName),Info)<0) or fpS_ISDIR(info.st_mode) then
    exit(-1)
  else
    Result:=UnixToWinAge(info.st_mtime);
end;
---------------------------------------

The FPC documentation for fpstat() mentions that a zero return value
means success, and any non-zero value means failure.

So shouldn't the above usage rather be written as follows (just like
the example code show in the FPC documentation):


  If  (fpstat (pointer(FileName),Info)<>0) or fpS_ISDIR(info.st_mode) then
     ....



-- 
Regards,
  - Graeme -


_______________________________________________
fpGUI - a cross-platform Free Pascal GUI toolkit
http://fpgui.sourceforge.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sysutils.pp.patch
Type: text/x-patch
Size: 441 bytes
Desc: not available
URL: <http://lists.freepascal.org/pipermail/fpc-devel/attachments/20111114/c1844615/attachment.bin>