[fpc-devel] [PATCH] patch to allow TUnzipper to load it's zip file from wherever

[Michael Van Canneyt]

On Mon, 3 Aug 2009, Graeme Geldenhuys wrote:

> Andrew Haines wrote:
>
> ==================
> @@ -377,15 +378,17 @@
>
>   TUnZipper = Class(TObject)
>   Private
> +    FOnCloseInputStream: TOpenStreamEvent;
>     FOnCreateStream: TOnCustomStreamEvent;
>     FOnDoneStream: TOnCustomStreamEvent;
> +    FOnOpenInputStream: TOpenStreamEvent;
> ==================
>
> I would suggest you find a more generic name for the event type. Having a 
> TOpenStreamEvent for a OnCloseInputStream doesn't sound right, and can lead 
> to confusion months down the line when somebody else looks at the code.
>
> If you want to use the event type for both OnClose... and OnOpen... then 
> maybe you should change that event type name to TInputStreamEvent or 
> something like that.  Or create two event types - one for each event, even 
> though there signature is the same.

I'll handle that prior to committing the patch.

Michael.