[fpc-devel] zstream, fpc and lazarus

[Michael Van Canneyt]

On Sat, 1 Dec 2007, Daniël Mantione wrote:

> 
> 
> Op Fri, 30 Nov 2007, schreef Vincent Snijders:
> 
> > Daniël Mantione schreef:
> > > 
> > > Op Mon, 26 Nov 2007, schreef Paul Ishenin:
> > > 
> > > > Daniël Mantione wrote:
> > > > 
> > > > > This patch is not correct because there might still be unread
> > > > > data in the
> > > > > zlib data buffers; this patch makes no attempt to flush them.
> > > > > 
> > > > > Daniël
> > > > This patch only do repositioning of Source stream to apropriate
> > > > position and
> > > > this solves crash reason of png reader (which lazarus uses a lot).
> > > > All other
> > > > logic is out of my current interests.
> > > 
> > > Yes, but instead of refusing restarts, it would support them in a buggy
> > > way. If you support something, you should support it correctly.
> > > 
> > > > I believe you know things better and do
> > > > all other fixes (since you are implementer).
> > > 
> > > I'll look at it.
> > > 
> > 
> > In the meantime, can this patch applied with {$IFDEF
> > ZSTREAM_BUGGY_QUICKFIX}...{$ENDIF}
> 
> If committed a proper fix, as bonus you can now randomly seek through the 
> compressed file, there are no limitations anymore.

Provided the source stream supports seeking, obviously...

Michael.